diff --git a/Misc/NEWS.d/next/Library/2026-10-21-19-55-00.gh-issue-159739.sque01.rst b/Misc/NEWS.d/next/Library/2026-10-21-19-55-00.gh-issue-159739.sque01.rst new file mode 100644 index 000000000000000..120caf1e27c6cba --- /dev/null +++ b/Misc/NEWS.d/next/Library/2026-10-21-19-55-00.gh-issue-159739.sque01.rst @@ -0,0 +1,2 @@ +Avoid a crash when a :class:`queue.SimpleQueue` subclass finalizer adds an +item after construction fails. diff --git a/Modules/_queuemodule.c b/Modules/_queuemodule.c index af54e42a6af584c..6779193e402fac9 100644 --- a/Modules/_queuemodule.c +++ b/Modules/_queuemodule.c @@ -51,13 +51,14 @@ RingBuf_Init(RingBuf *buf) { buf->put_idx = 0; buf->get_idx = 0; - buf->items_cap = INITIAL_RING_BUF_CAPACITY; + buf->items_cap = 0; buf->num_items = 0; - buf->items = PyMem_Calloc(buf->items_cap, sizeof(PyObject *)); + buf->items = PyMem_Calloc(INITIAL_RING_BUF_CAPACITY, sizeof(PyObject *)); if (buf->items == NULL) { PyErr_NoMemory(); return -1; } + buf->items_cap = INITIAL_RING_BUF_CAPACITY; return 0; }