Skip to content

Support to show keyboard keys based on locales - #161

Open
bfritscher wants to merge 2 commits into
Code52:masterfrom
bfritscher:locale-keyboard-support
Open

bfritscher wants to merge 2 commits into
Code52:masterfrom
bfritscher:locale-keyboard-support

Conversation

@bfritscher

Copy link
Copy Markdown
Contributor

This fixes partially issue #110 and #65.

Keys are now showed after transforming them with win32 KeyCodeToUnicode.
If a ctrl or alt is used it defaults to the lowercase default letter => shortcut
If shift is pushed without ctrl or alt it shows directly the mapped character, as was handled before with the hardcoded list, but now it is locale specific and automatic.

However there are some improvements which could be added:

  • correct handling of dead keys
  • Keymaps parsing still uses the hardcoded values.
  • alt-gr shows as ctrl + alt + base key instead of special character

@hnrkndrssn hnrkndrssn self-assigned this Jul 16, 2017
@bfritscher

Copy link
Copy Markdown
Contributor Author

Based on the tests shortcuts letters have to be capital?

@doggy8088

Copy link
Copy Markdown

Hi there! 👋

I (@doggy8088 / Will Huang) have stepped in to take over active maintenance of Carnac at doggy8088/carnac (project website: https://carnac.gh.miniasp.com/).

This issue regarding international keyboard layouts and Chinese localization has been resolved in my fork!
Thank you @bfritscher for contributing this PR! We ported your Win32 ToUnicodeEx keyboard layout translation into our fork (doggy8088#30), made it configurable via the UseKeyboardLayoutNames setting (enabled by default), and ensured dead-key state is preserved safely.

Context & What Changed

Availability

  • Source Code: Available now on the dev branch of doggy8088/carnac.
  • Upcoming Release: This will be included in the next official release, which will be published to GitHub Releases (both installer and portable .zip), WinGet (winget install doggy8088.Carnac), and Chocolatey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants