Repository navigation
Increase slow Java 11 test timeouts on ARM64 CI - #13037
AlexeyKuznetsov-DD wants to merge 2 commits into
Conversation
Give java-concurrent and servlet tests 30 minutes on Linux ARM64 CI with a Java 11 test launcher. Keep the existing timeout for other runs. [ci: ARM64, NON_DEFAULT_JVMS]
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
The 30-minute timeout is confined to regular Java 11 tests on Linux ARM64 CI. Other Java versions, environments, and test suites retain their existing timeout.
🤖 Bits Code Review · Commit a70a5f1
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Increase the regular
testtask timeout from 20 to 30 minutes injava-concurrent-1.8andjavax-servlet-3.0whenCIis present,HostPlatform.isLinuxArm64()is true, and the selected test launcher is Java 11.Motivation
Repeated agent installation makes class retransformation expensive on Java 11 HotSpot. JDK-8139551 batches code-cache invalidation, but the Java 11 builds investigated still use the older implementation. These suites can exceed the existing task timeout while making progress: a diagnostic java-concurrent run completed in approximately 26 minutes, and a completed servlet run took approximately 19 minutes.
Give these two suites additional headroom while the test-harness lifecycle is addressed separately.
Additional Notes
Observed failure:
Dumps from timed-out suites show
AgentInstaller.installBytebuddyAgentinInstrumentationSpecification.setupSpec, consistent with installation overhead.Validation: asserted 18 resolved task-timeout values across the two modules'
test,forkedTest, andlatestDepTesttasks, using Gradle dry runs with Java 11/17 and a simulated Linux ARM64 host. Only regular Java 11 tests withCIpresent resolve to 30 minutes; Java 17 and non-CI runs resolve to 20 minutes. Both modules' Spotless formatting passed. Full test suites were not executed.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue