Repository navigation
Honor SETUPTOOLS_EXT_SUFFIX for limited-API builds - #623
Open
jameshilliard wants to merge 1 commit into
Open
jameshilliard wants to merge 1 commit into
jameshilliard wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setuptools honors
SETUPTOOLS_EXT_SUFFIXwhen generating extension filenames, but setuptools-rust always removes the length of the sysconfigEXT_SUFFIXwhen replacing it with a stable-ABI suffix. An override with a different length can truncate the module name or leave part of the old suffix in the filename.Use the nonempty environment override to determine the suffix being replaced, falling back to sysconfig for unset or empty overrides, matching setuptools.
Add regression tests covering unset, empty, shorter, and longer overrides with unqualified and platform-qualified ABI3/ABI3T suffixes,
.pyd, and platforms without a stable-ABI suffix. Add a changelog entry.Testing
rust.abi3.sofilename andcp39-abi3-linux_aarch64wheel tags, and imported and executed successfully under QEMU with Python 3.14.