Repository navigation
Fix CLI session loss on background refresh failures - #8946
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #8945
A background refresh failure currently clears every saved account. Concurrent refreshes can race on stale session data, while theme dev only logs failures at debug level.
WHAT is this pull request doing?
Refreshes and updates the latest session under a shared file lock, preserves unrelated accounts, and removes only a session whose credentials were rejected. Theme dev warns when interactive reauthentication is needed. Regression tests cover concurrent refreshes, targeted cleanup and the warning. Focused CLI auth/store tests (79), Theme environment tests (246), type-check, lint and builds passed for both packages.
How to manually test your changes?
With two saved CLI accounts, trigger a no-prompt refresh failure for one and confirm the other remains selectable. In
shopify theme dev, confirm the failed background refresh produces a terminal warning.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add