Repository navigation
[Refactor] Group security issues declaratively with groupBy - #8981
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Replace the manual Map accumulation in groupIssues with the cli-kit groupBy helper, deriving each group's issues and distinct files from the grouped entries instead of mutating accumulator arrays. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
groupIssuesin the app security engine built its result by hand: aMap<string, IssueGroup>, a branch for "group exists" vs "first time seeing this key", and mutation of the accumulator'sissuesandfilesarrays. The grouping intent was obscured by the bookkeeping, and the de-duplication of file names was anincludescheck buried inside the loop.WHAT is this pull request doing?
Replace the manual
Mapaccumulation with the existinggroupByhelper from@shopify/cli-kit/common/collection, already used elsewhere in this package (services/generate.ts,services/dev/app-events/app-event-watcher.ts). Each group'sseverity,issues, and distinctfilesare now derived from the grouped entries rather than accumulated through mutation, and the file de-duplication becomes aSet.Behavior is unchanged. The sort that establishes ordering is untouched, and group ordering is still first-appearance order:
groupKeyjoins its parts with|, so keys are never integer-like andObject.valuespreserves insertion order exactly as theMapdid.How to manually test your changes?
The grouped issue list, its ordering, and the per-group file lists should be identical to before.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add