Skip to content

Fix delayed development store provisioning and E2E cleanup - #8985

Open
isaacroldan wants to merge 2 commits into
mainfrom
codex/fix-e2e-store-provisioning
Open

isaacroldan wants to merge 2 commits into
mainfrom
codex/fix-e2e-store-provisioning

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

CI failed store creation before provisioning finished. Lifecycle cleanup then returned before the stores appeared, leaving both stores behind in later runs. See the creation failure and later store list.

WHAT is this pull request doing?

  • Retry missing store creation records within the existing five-minute polling limit. Missing organizations, terminal statuses, and request errors still stop the command.
  • After a failed lifecycle test, wait up to one minute for the exact temporary store before deleting it. Report unresolved cleanup if it remains absent, and keep ownership and protected-store checks.

Validation: 13 store-creation tests and 28 local cleanup/helper tests pass. The new regression cases fail on the original implementation. Targeted ESLint and TypeScript checks for both affected packages pass. Remote E2E validation will run in CI.

How to manually test your changes?

In a development organization, create a store with a unique name:

pnpm shopify store create dev --name <unique-name> --organization-id <org-id> --plan basic --country US --no-demo-data --json

Confirm the command waits for provisioning and returns the store domain. Delete that store afterward:

pnpm shopify store delete --store <returned-domain> --organization-id <org-id> --force --json

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact

@isaacroldan
isaacroldan requested a review from a team as a code owner October 22, 2026 15:39
@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Oct 22, 2026
@github-actions github-actions Bot added no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. and removed Area: @shopify/cli @shopify/cli package issues labels Oct 22, 2026
@isaacroldan
isaacroldan added this pull request to the merge queue Oct 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 23, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants