Repository navigation
Stop app dev watching build output and other never-source paths - #8992
Draft
isaacroldan wants to merge 1 commit into
Draft
isaacroldan wants to merge 1 commit into
isaacroldan wants to merge 1 commit into
Conversation
Chokidar ignored only node_modules and .git, so it crawled (and on macOS, without fsevents, polled) every file under a Rust function's target directory. The per-extension watch rules only filter events after chokidar emits them. Ignore at the watcher level the paths that are never an extension's source or an import: Cargo target directories (a target directory next to a Cargo.toml), function output directories (dist), the CLI's .shopify directory, .DS_Store and editor swap/backup files. dist and generated stay watched for other extensions, because imported files can live there. Co-authored-by: Isaac Roldan <isaac.roldan@shopify.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chokidar ignored only node_modules and .git, so it crawled (and on macOS, without fsevents, polled) every file under a Rust function's target directory. The per-extension watch rules only filter events after chokidar emits them.
Ignore at the watcher level the paths that are never an extension's source or an import: Cargo target directories (a target directory next to a Cargo.toml), function output directories (dist), the CLI's .shopify directory, .DS_Store and editor swap/backup files. dist and generated stay watched for other extensions, because imported files can live there.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to manually test your changes?
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add