Repository navigation
fix: add base64 gem dependency for Ruby 3.3+ compatibility - #2108
wasim-builds wants to merge 4 commits into
Conversation
The base64 gem is no longer part of the default gems since Ruby 3.4.0. Without an explicit dependency, requiring it on Ruby 3.3+ produces a deprecation warning, and on Ruby 3.4+ it will raise a LoadError. The bigdecimal gem was already added as a dependency to address the same issue; this adds base64 to complete the fix for Shopify#1772.
|
I have signed the CLA! |
|
By the way, I've really been enjoying contributing to this project! My goal is to get more involved in open source to help maintain projects and learn from great engineering teams. Is there a process or pathway for becoming a member of the Shopify GitHub organization? I'd love to continue helping out where I can! |
|
Hey 👋 Quick bump on this one — it's a small fix adding the gem dependency for Ruby 3.3+ compatibility. No rush, just a friendly ping! 🙏 |
|
Hi! Bumping this — adds the base64 gem dependency for Ruby 3.3+ compatibility. Small fix, CLA signed, ready for review! |
|
Hi team, Following up on this PR regarding fix: add base64 gem dependency for Ruby 3.3+ compatibility in Shopify/liquid. Working on Liquid template parsing, Ruby runtime compatibility, and gem dependencies has been a great experience, and I am very keen to continue contributing to Shopify/liquid. Beyond open-source contributions, I'm open to full-time roles, contract/freelance work, or collaborating more closely as a team member. Feel free to explore my open-source work and profile here: https://github.com/wasim-builds. |
Summary
Adds the
base64gem as an explicit dependency inliquid.gemspec.Problem
The
base64gem was loaded from the standard library in Ruby 3.3, producing this deprecation warning:Starting with Ruby 3.4, the
base64gem is no longer part of the default gems, meaningrequire 'base64'will raise aLoadErrorunless the gem is explicitly depended on.This is the second half of the fix for #1772 -- the
bigdecimaldependency was already added previously.Changes
liquid.gemspec: Addeds.add_dependency("base64")Testing
This is a gemspec-level dependency declaration change. No code logic is modified, so existing tests continue to pass. The fix ensures that
require 'base64'inlib/liquid/standardfilters.rbworks without deprecation warnings on Ruby 3.3+ and without errors on Ruby 3.4+.