Repository navigation

Report instructions causing side-exits in `--ujit-stats` #29

Closed

Assignees

opened

on Jan 26, 2021

It would be very useful to know which instructions trigger exits to the interpreter and how often, and display a list sorted by decreasing frequency. That will help us target our efforts to increase coverage.

The simplest way to implement this would be to call a method which takes note of which opcode is at the exit_pc in ujit_gen_exit(). Maybe we can generate a call to a function that takes the exit PC as a parameter when RUBY_DEBUG is set.

https://github.com/Shopify/ruby/blob/microjit/ujit_codegen.c#L55

maximecb
assigned
XrXr
on Jan 26, 2021
XrXr
added a commit that references this issue on Jan 27, 2021
Tally instructions when taking side exists for --ujit-stats
c4eec85
XrXr
closed this as completed on Jan 27, 2021
tenderlove
added a commit that references this issue on Apr 20, 2021
check ep during compaction because it can be null
8e18d82
peterzhu2118
added a commit that references this issue on Apr 21, 2021
check ep during compaction because it can be null
32643cf
casperisfine
added a commit that references this issue on May 19, 2021
check ep during compaction because it can be null
34cd372
tenderlove
added a commit that references this issue on Jun 2, 2021
Implement opt_mod as call to interpreter function (#29)
ded23b6
noahgibbs
added 3 commits that reference this issue on Sep 29, 2021
Tally instructions when taking side exists for --ujit-stats
8a8baf8
Tally instructions when taking side exists for --ujit-stats
1ca8b22
Tally instructions when taking side exists for --ujit-stats
6fe8372
noahgibbs
added a commit that references this issue on Oct 11, 2021
Tally instructions when taking side exists for --ujit-stats
0b8b7bd
noahgibbs
added a commit that references this issue on Oct 18, 2021
Tally instructions when taking side exists for --ujit-stats
5bea92b
XrXr
added a commit that references this issue on Oct 19, 2021
Tally instructions when taking side exists for --ujit-stats
e2bb642
maximecb
added a commit that references this issue on Oct 19, 2021
Implement opt_mod as call to interpreter function (#29)
60aae3e
noahgibbs
added a commit that references this issue on Oct 20, 2021
Tally instructions when taking side exists for --ujit-stats
b45295e
1 remaining item
XrXr
added 6 commits that reference this issue on Oct 20, 2021
Tally instructions when taking side exists for --ujit-stats
cbe0011
Implement opt_mod as call to interpreter function (#29)
2089820
Tally instructions when taking side exists for --ujit-stats
0da853b
Implement opt_mod as call to interpreter function (#29)
ff2752d
Tally instructions when taking side exists for --ujit-stats
3c7251b
Implement opt_mod as call to interpreter function (#29)
c9feb72
maximecb
added a commit that references this issue on Aug 2, 2023
Fix crash in NoMethodError for dummy frames
1d096c1
casperisfine
added a commit that references this issue on Sep 20, 2023
merge revision(s) 1d096c1: [Backport #19793]
3c9cb70
st0012
added a commit that references this issue on Nov 30, 2024
Fix use-after-free in constant cache
f65a6c0
peterzhu2118
added a commit that references this issue on Dec 3, 2024
Fix use-after-free in constant cache
4c4ed3f
naithianee
added a commit that references this issue on Nov 25, 2025
Shopify/ruby#29
80ce959
rwstauner
added a commit that references this issue on Dec 19, 2025
merge revision(s) f65a6c0: [Backport #20921]
1b1c6e6
ChrisBr
added a commit that references this issue on Feb 9, 2026
Fix use-after-poison
5fdb124
manc-zolt4
added a commit that references this issue on Jul 27, 2026
Shopify/ruby#29
9883ec1
schs01ilzogtb
added a commit that references this issue on Sep 9, 2026
Shopify/ruby#29
cf9667b

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

XrXr

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests