Repository navigation
Conversation
The examples of labelled imports and exports used `wasi:keyvalue/store` and `wasi:http/handler`. Use the `local:demo` interfaces that the rest of WIT.md uses instead, so the examples don't read as a statement about which WASI interfaces hosts should support under a label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples of labelled imports and exports use
wasi:keyvalue/storeandwasi:http/handler, which can read as saying that hosts should support those WASI interfaces under labels. Whether that makes sense depends on the interface and the host (see the discussion of a labelledwasi:ioin bytecodealliance/wasmtime#14916). So this switches the examples to thelocal:demo/storeandlocal:demo/handlerinterfaces that the rest of WIT.md uses. The examples are otherwise unchanged.LLM summary of the changes
version-suffix,implementsandexternal-idexamples, and the text around them, uselocal:demo/store. "a standard static host implementation" becomes "a single static host implementation", since the interface is no longer a standard one.use-pathand@external-idworld examples, and the text around them, uselocal:demo/storeandlocal:demo/handler.wasi:http/handleraren't about labels, so they stay.