Repository navigation
Conversation
…ration Karma migration The Karma to Vitest migration moves build-only test options such as `styles` into a `testing` build configuration and points the test target at it. For each test configuration it created a separate `testing-<name>` build configuration containing only that configuration's own options. Because a test configuration's `buildTarget` replaces the base one, running `ng test --configuration <name>` lost the options moved from the base test options. Merge the base options into each per-configuration build configuration, with the configuration's own values taking precedence.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Karma to Vitest migration schematic to correctly handle inheritance of base test options in per-configuration build settings. It ensures that custom build options are properly merged, preventing potential configuration loss. The review feedback highlights a potential issue with spreading undefined base options and provides a safer implementation using a guard clause.
thekhegay
reviewed
Oct 20, 2026
MeAkib
force-pushed
the
fix/karma-vitest-config-build-options
branch
from
October 21, 2026 02:04
ac2914d to
8df4cb6
Compare
…configuration Karma migration
…configuration Karma migration
MeAkib
force-pushed
the
fix/karma-vitest-config-build-options
branch
from
October 21, 2026 02:06
8df4cb6 to
5846b18
Compare
alan-agius4
added
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Karma to Vitest migration moves build-only test options such as
stylesinto atestingbuild configuration and points the test target at it. For each test configuration it created a separatetesting-<name>build configuration containing only that configuration's own options. Because a test configuration'sbuildTargetreplaces the base one, runningng test --configuration <name>lost the options moved from the base test options.Merge the base options into each per-configuration build configuration, with the configuration's own values taking precedence.