Repository navigation
fix(ci): shard full test suites and preserve local fast-test - #1856
Merged
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49a5d083f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR tests took roughly half an hour. This change runs complete suites in parallel file groups through the existing justfile flow. CI uses no testmon tracing or dependency caches; local
just fast-testandjust testmon-refreshretain incremental selection.The Postgres integration recipe also accepted exit 137 after killing tests at only 9% completion. Failed or killed runs now fail the gate.
What changed
Validation
Performance and remaining evidence
The first traced trial exposed excessive overhead: the same overlapping-save test passed locally in 52.95 seconds untraced versus 136.05 seconds with tracing. CI therefore uses sharding alone, while developers can opt into local incremental selection.
No tests were removed. Full Postgres integration now reaches tests previously cut off by the timeout workaround. Compare complete workflow time and shard imbalance after this run before considering more runners or test reductions. Baseline details are in
docs/test-performance.md.