Repository navigation
Conversation
1 task done
adario
marked this pull request as ready for review
October 24, 2026 15:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two bugs in
ShapeHitboxwhen a hitbox is removed and re-added:_validAabbis only reset by the transform listeners, whichonRemovedetaches. If an ancestor moves while the hitbox is removed, the re-added hitbox keeps its old
aabb, so the broadphase,raycast,containsPointand the collision callbacks use the oldposition. This also happens when the hitbox is removed and added again together with its
parent.
onMountnow marks the bounds as invalid.onMountappends to_transformAncestorsand never clears it, soeach re-mount adds the ancestors again and
onRemovewalks the whole list.onRemovenowclears it.
A hitbox that fills its parent (no explicit size) hid the first bug, since filling the parent
recomputes the bounds on mount.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #4141