Skip to content

docs: correct toolset flag precedence - #3585

Open
pei711 wants to merge 1 commit into
github:mainfrom
pei711:fix/3578-document-toolset-flag-precedence
Open

pei711 wants to merge 1 commit into
github:mainfrom
pei711:fix/3578-document-toolset-flag-precedence

Conversation

@pei711

@pei711 pei711 commented Oct 25, 2026

Copy link
Copy Markdown

Summary

Correct the GITHUB_TOOLSETS precedence statement in the README.

Why

When both values are set, Viper honors an explicitly changed --toolsets flag before the environment variable. The current sentence says the reverse. Fixes #3578.

What changed

  • Clarify the precedence between an explicitly provided --toolsets flag and GITHUB_TOOLSETS.

MCP impact

  • No tool or API changes

Security / limits

  • No security or limits impact

Tool renaming

  • I am not renaming tools as part of this PR

Lint & tests

  • Documentation generation: go run ./cmd/github-mcp-server generate-docs
  • git diff --check

Docs

  • Updated (README / docs / examples)

AI assistance: Codex assisted with issue analysis, the wording change, and local validation.

@pei711
pei711 requested a review from a team as a code owner October 25, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README: GITHUB_TOOLSETS doesn't take precedence over --toolsets (viper gives the flag priority)

1 participant