Repository navigation
Magento2: keep shared deployment configuration trackable - #4933
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to the application or project's homepage
Magento Open Source
Reasons for making this change
The Magento 2 template ignores
app/etc/config.php, hiding the shared deployment configuration (including enabled modules) from a project's initial commit. Adobe's deployment workflow explicitly requires this file to be versioned and shared across development, staging and production.Remove that ignore rule and explain the distinction beside
app/etc/env.php, which remains ignored because it contains environment-specific and sensitive settings. This only changes the Magento 2 community template.Validation with a fresh Git repository and
git check-ignore --quiet --no-index: before the change, the shared configuration is incorrectly ignored; afterward, all 17 path checks pass. These includeenv.php, generated code, vendor files, cache/static/media output, the existing.htaccessexceptions, application source and Composer manifests.git diff --checkpasses.AI assistance was used to investigate and validate this change.
Links to documentation supporting these rule changes
config.phpas shared configuration that should be checked into source control.config.phpfrom environment-specific and sensitiveenv.php.Merge and Approval Steps