Skip to content

Commenting on unchanged lines in a pull request #347

Closed as not planned
Closed as not planned
Commenting on unchanged lines in a pull request#347
Labels
GAFeature phase: Generally availableallProduct SKU: AllcloudAvailable on CloudexploringFeature phase: Exploringpull requestsFeature: Github Pull RequestsserverAvailable on Server

Description

@github-product-roadmap
github-product-roadmap
opened on Dec 15, 2021

Summary

Review comments are the primary way reviewers provide feedback to the author and other reviewers during the review phase of a pull request, but currently comments can only be added to the 3 lines before or after a changed line. We intend to allow users to add comments and suggest changes on any line in any file changed in the pull request.

image

Intended Outcome

This will improve the review experience and increase review quality by allowing users to comment on lines that were not changed (but maybe should have been). Users will no longer need to add a comment to a random changed line and reference a line number when providing feedback about missing a change.

How will it work?

A users can add a comment, reply to a comment, or suggest changes to any line of a changed file, not just the 3 lines surrounding a change.

Activity

  1. github
    locked and limited conversation to collaborators on Dec 15, 2021
  2. github-product-roadmap
    added
    allProduct SKU: All
    cloudAvailable on Cloud
    code
    GAFeature phase: Generally available
    on Dec 15, 2021
  3. Sid-ah
    added this to GitHub Public Roadmapon Dec 15, 2021
  4. Sid-ah
    moved this to Q1 2022 – Jan-Mar in GitHub Public Roadmapon Dec 15, 2021
  5. alexcnichols
    moved this from Q1 2022 – Jan-Mar to Q4 2022 – Oct-Dec in GitHub Public Roadmapon Apr 13, 2022
  6. github-product-roadmap
    added
    serverAvailable on Server
    on May 18, 2022
  7. ankneis
    added
    pull requestsFeature: Github Pull Requests
    on Dec 21, 2022
  8. github-product-roadmap
    removed
    code
    on Jan 25, 2023
  9. ankneis
    moved this from Q4 2022 – Oct-Dec to Future in GitHub Public Roadmapon May 8, 2023
  10. github-product-roadmap
    added
    exploringFeature phase: Exploring
    on May 10, 2023
  11. ankneis
    added this to GitHub Public Roadmapon Sep 19, 2023

  12. ankneis commented on Nov 20, 2024

    @ankneis
    ankneis
    on Nov 20, 2024
    Contributor

    Please continue to refer to our updated Public Roadmap for the latest ships, including updates on the continuation of these projects. For more information, please check out this Discussion post.

  13. ankneis
    closed this as not plannedon Nov 20, 2024

  14. ankneis commented on Nov 26, 2024

    @ankneis
    ankneis
    on Nov 26, 2024
    Contributor

    We wanted to provide more details on why this issue was removed from the public roadmap. Code review improvements remain a key priority for us. We're removing this issue from the roadmap while we develop more certainty around our scope and timelines.

    In the meantime, we’d love for you to upvote and share your thoughts in this dedicated discussion, else start a new discussion if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GAFeature phase: Generally availableallProduct SKU: AllcloudAvailable on CloudexploringFeature phase: Exploringpull requestsFeature: Github Pull RequestsserverAvailable on Server

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions