Repository navigation
fix(app): offer PR actions only when they can work, and say what GitHub and the terminal mean - #587
Merged
Merged
Conversation
…ub and the terminal mean Merge waits for nothing left to commit or push; Ready for review and Fix checks appear only on pull requests the channel owner's GitHub account wrote. A dismissed checks notice stays dismissed across reloads. GitHub's "Could not resolve to a Repository" becomes a sentence about the origin and access. A terminal whose shell the host lost says so. Choosing a project on a phone closes the drawer over Issues and PRs. Why: apps/app/src/git.ts#function useGit | the agent pushes as the channel owner's GitHub account, so Fix and Ready for review only work on that account's pull requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-train task "PR actions, React loop and error text". Map ids: ^720 ^719 ^724 ^725 ^743 ^633 ^770 ^811.
git.ts).GraphQL: Could not resolve to a Repository …becomes a sentence about the origin and the gh account's access; other GraphQL errors say "GitHub refused the request:".Smoked on a loopback host from this lane: Merge offered on clean githubnext/ace-testbed#2 and hidden with a dirty file; Ready for review shown on my own draft and absent (with Fix) on honojs/hono#5535; notice dismissal survived a reload; a project with origin
githubnext/no-such-repo-fixbshowed the new sentence on Issues; restarting the host showed the new-shell line in an open terminal; at 390px the drawer closed after picking a project and PRs was reachable.Not covered: the PRs list for a missing repo shows "No open pull requests" because
gh pr list --searchreturns nothing instead of an error. The session-details checks list warns about a duplicate React key when GitHub lists the same check URL twice (codecov on hono#5535).Built in Ace
No. Built by Claude Code as a fix-train worker outside Ace, driving a loopback Ace host with Playwright for smoke tests; the fix train runs headless agents in parallel, which Ace doesn't orchestrate yet. See #5.