Repository navigation
FIX: Deduplicate overlapping scorer evaluation dataset paths - #3514
Open
Aman (its-amann) wants to merge 1 commit into
Open
Aman (its-amann) wants to merge 1 commit into
Aman (its-amann) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Richard Lundeen (richlundeen)
approved these changes
Oct 25, 2026
Richard Lundeen (richlundeen)
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Deduplicating the matched paths before loading prevents overlapping patterns from counting the same CSV twice, while keeping deterministic ordering.
Reviewed with GitHub Copilot.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3430.
When dataset patterns overlap, the same CSV can get matched more than once. It then gets loaded twice, which gives it extra weight in the evaluation and changes the reported accuracy. This PR removes duplicate paths right before the existing sorted loading step, so each file is only counted once.
Different files are still counted separately, even if they share the same dataset version. Sorting, version concatenation and registry behavior don't change.
Roman Lutz (@romanlutz), I kept the fix in the shared evaluator path, so it covers both objective and harm evaluations.
Tests and Documentation
./paths. They use real CSV loading,SubStringScorer, the metric calculation and an isolated SQLite memory.make unit-test-junit CMD='python -m' UNIT_TESTS=tests/unit/score).tyon the changed modules all pass. I rantyonly on the changed files instead of the fullty-checkhook, since the full one needs every optional dependency installed.