Repository navigation
TEST: Skip POSIX deployment and Docker signal tests on Windows - #3525
Open
Richard Lundeen (richlundeen) wants to merge 3 commits into
Open
Richard Lundeen (richlundeen) wants to merge 3 commits into
Richard Lundeen (richlundeen) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip the two POSIX cancellation rollback tests and 13 Docker smoke-test signal cases on Windows. Keep these tests enabled on Linux and macOS, with all cleanup and signal exit-code assertions unchanged. Keep all other deployment and Docker CI test cases enabled on Windows. No production code or CI failure policy changes.
This addresses the unrelated merge-queue failure for #3271 in build_and_test run 40173689239, job 121109753912. The Windows/Python 3.11/all-extras job reported 1 failure and 31,850 passes. In the SIGINT case of
test_cancellation_keeps_public_access_disabled_until_connection_removal, Git Bash exited with2147483652instead of the expected POSIX exit code130. These tests require POSIX signal handling, which is not reliable in Git Bash on Windows.The Docker cases use the same real INT/TERM signals to test a smoke script whose build workflow runs only on Ubuntu. Skip all 12 repeated-signal cleanup cases and only the signal parameter of the general smoke-failure test.
Tests and Documentation
No documentation changes are needed for these test-only platform skips.
Validation on Windows:
uv run --no-sync pytest tests\unit\infra\test_code_deployment.py -q -rs: passed, 35 tests passed, exactly the 2 intended cancellation tests skipped, and 102 subtests passed. A downloaded jq executable was added to PATH for this command; no repository dependency changes were made.uv run --no-sync pytest tests\unit\infra\test_docker_ci.py -q -rs: passed, 267 tests passed and exactly the 13 intended signal cases skipped.uv run --no-sync pre-commit run --all-files(withUV_NO_SYNC=1): all hooks passed, including after the Docker test changes.git diff --check: passed.Linux and macOS execution was not run locally; CI retains those platform checks.
JupyText was not run because no notebooks or executable documentation examples changed.