Repository navigation
Avoid storing duplicate SourceFile in createVirtualTypeScriptEnvironment (#3614) - #3684
Open
Hrushikesh Ramilla (Hrushikesh-ramilla) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3614
Problem
In createVirtualTypeScriptEnvironment, createFile and updateFile currently parse a full s.SourceFile AST and pass it to the compiler host (updateFile), which stores it in its internal sourceFiles map.
However, the language service never reads that map — its host's getScriptSnapshot reads raw text from sys, and the language service parses and caches its own SourceFile ASTs from those snapshots.
As a result, every file in the virtual TypeScript environment is held in memory as two duplicate ASTs.
Solution
Verification
pm test in packages/typescript-vfs: 25 / 25 tests passed (including new tests).