Repository navigation
Javascript should support defineProperty assignments to exports #22439
Description
// @noEmit: true
// @allowJs: true
// @checkJs: true
// @Filename: defaults.js
exports.Umask = Umask
function Umask() {}
Object.defineProperty(exports, 'defaults', {
get: function() {
return 1
}
})
// @Filename: use.js
var def = require('./defaults').defaults
var one = defExpected behavior:
defaults is bound
Actual behavior:
defaults is not bound
Activity
mhegazy commentedon Mar 9, 2018
Looks like the same issue as #6651. In the past we have chose not to support such patterns, in general.
hpmax00 commentedon Sep 12, 2018
Mohamed Hegazy (@mhegazy) In the fruture, can you support this?
sandersn commentedon Sep 12, 2018
hpmax00 We decide which patterns to support by the amount of usage we observe in popular code bases, plus upvotes on this issue. Right now I haven't seen many of either, but that might change in the future.
weswigham commentedon Nov 6, 2018
We should support this in
3.2thanks to #27208.