Refactoring suggtion: convert to namespace import #24044

Activity

1. Mohamed Hegazy (mhegazy)

   added

   SuggestionAn idea for TypeScriptAn idea for TypeScript

   on May 10, 2018
3. Mohamed Hegazy (mhegazy)

   added

   Domain: LS: Refactoringse.g. extract to constant or function, rename symbole.g. extract to constant or function, rename symbol

   Awaiting More FeedbackThis means we'd like to hear from more people who would be helped by this featureThis means we'd like to hear from more people who would be helped by this feature

   on May 10, 2018
4. mjbvz commented on May 11, 2018

   

   Matt Bierner (mjbvz)

   on May 11, 2018

   ContributorAuthor

   More actions

   Yes managing this automatically would also be nice. However a refactor that I can trigger would also be useful, as there are some module that I always want to use namespace imports for. I originally opened this issue because I noticed myself converting a lot of imports like:

   import {red, green blue} from 'vs/colors';

   to:

   import * as colors from 'vs/colors'

   Even when only a single value is used from vs/colors, I prefer using the namespace for this module
5. DanielRosenwasser commented on May 17, 2018

   

   Daniel Rosenwasser (DanielRosenwasser)

   on May 17, 2018

   Member

   More actions

   Looks like a duplicate of #19260
6. Mohamed Hegazy (mhegazy)

   assigned

   ghost

   on May 17, 2018
7. Mohamed Hegazy (mhegazy)

   added this to the TypeScript 3.0 milestone on May 17, 2018
8. cancerberoSgx commented on May 21, 2018

   

   Sebastián Gurin (cancerberoSgx)

   on May 21, 2018

   More actions

   My humble opinion / question:

   • If you only provide this refactor and not the reverse one (* to named import) then people might think TypeScript is promoting this kind of imports. Make sure you want to do that or provide the reverse transformation.
   • In my experience developing typescript refactors, non named imports like the one you are suggesting could make it harder to navigate the AST for global refactors when you have to refactor imports / exports globally (think for example on refactors like move class to other file, move method to other class/interface, etc)

   My two cents
9. ghost added

   FixedA PR has been merged for this issueA PR has been merged for this issue

   on May 29, 2018
10. ghost closed this as completedin #24469on May 30, 2018
11. microsoft

    locked and limited conversation to collaborators on Jul 31, 2018