Repository navigation
TSX variable element #8549
Description
TypeScript Version:
1.8.10
Code
export class Text extends React.Component<TextProps, {}> {
_tagName: string = 'div';
render() {
return (
<this._tagName />
);
}
}
export class Heading1 extends Text {
_tagName:string = 'h1';
}Expected behavior:
No error
Actual behavior:
Throws compilation error 'Cannot find name this'
Workaround
export class Text extends React.Component<TextProps, {}> {
_tagName: string = 'div';
render() {
const self = this;
return (
<self._tagName />
);
}
}
export class Heading1 extends Text {
_tagName:string = 'h1';
}
Activity
basarat commentedon May 11, 2016
Another:
Error : JSX element t.tag does not have construct or call signatures.I guess its valid to tag if the variable resolves to a
stringinstead of aCall/Construct.Warning
But not if its not
dottede.g. the following :is actually creating a
React.createElement("tag")and notReact.createElement("h1"). To be honest this whole use a string to point to what you want feels wrongish to me.Type
Note : The type will probably have to resolve to
anyat least to begin with and it is going to be a pain 🌹yuit commentedon Jun 14, 2016
Nathan Shively-Sanders (@sandersn) could i take this bug ?
sandersn commentedon Jun 14, 2016
Sure, I haven't looked at it at all.
yuit commentedon Jun 23, 2016
Update on the decision we made, after talk with Ryan Cavanaugh (@RyanCavanaugh) about this. We made following decision:
So in both examples pointed out by Rylan Hawkins (@RylanH) and Basarat Ali Syed (@basarat) , the type will be anyType and no error should be reported. if you would like a tighter check, you will want to give it a string literal type