[Hardik K (hardikkaurani)]

Summary

Addresses OpenTelemetry span lifecycle and isolation in kiota_http:

1. Encloses downstream execution in UserAgentHandler within the handler span lifecycle (try...finally: _span.end()) and records downstream pipeline errors via _span.record_exception(exc).
2. Prevents per-request parent_span options from mutating BaseMiddleware.parent_span on the middleware instance, isolating trace contexts between requests.
3. Adds defensive null request checks and telemetry exception recording to UrlReplaceHandler and UserAgentHandler.

Fix

• middleware.py (BaseMiddleware._create_observability_span):
  • Bound per-request parent_span locally instead of mutating self.parent_span. Subsequent requests processed by the same middleware instance without a parent_span option no longer inherit earlier trace spans.
• user_agent_handler.py (UserAgentHandler.send):
  • Added null check if request is None: raise TypeError("request cannot be null").
  • Moved _span.end() into a finally block enclosing await super().send(request, transport) so the span accurately measures full execution and downstream spans remain properly nested.
  • Added exception handling to record errors on the span before re-raising (_span.record_exception(exc)).
• url_replace_handler.py (UrlReplaceHandler.send):
  • Added null check if request is None: raise TypeError("request cannot be null").
  • Added exception handling to record errors on the span before re-raising (_enable_span.record_exception(exc)).
• Unit Tests:
  • test_base_middleware.py: Added test_parent_span_option_does_not_mutate_middleware_instance verifying request options do not leak parent spans across requests.
  • test_user_agent_handler.py: Added tests verifying null request rejection, span enclosing transport, and exception recording on transport failure.
  • test_url_replace_handler.py: Added tests verifying null request rejection and exception recording on transport failure.

Testing

• Ran all targeted middleware tests:

  pytest packages/http/httpx/tests/middleware_tests/test_user_agent_handler.py packages/http/httpx/tests/middleware_tests/test_url_replace_handler.py packages/http/httpx/tests/middleware_tests/test_base_middleware.py
  

  Result: 21/21 tests PASS in 0.12s.
• Ran full HTTP test suite:

  pytest packages/http/httpx/tests
  

  Result: 205/205 tests PASS in 68.90s.

cc Vincent Biret (@baywet)

[Hardik K (hardikkaurani)]

Hi Vincent Biret (@baywet),

Following up on our middleware work in kiota_http, this PR addresses OpenTelemetry span lifecycle and isolation:

• Encloses UserAgentHandler.send within the span lifecycle ( ry...finally: _span.end()) so downstream operations remain nested within the handler span, and records pipeline exceptions via _span.record_exception(exc).
• Prevents per-request parent_span options from mutating BaseMiddleware.parent_span on the middleware instance, ensuring trace contexts remain strictly isolated between requests.
• Adds defensive null request checks and telemetry exception recording to UrlReplaceHandler and UserAgentHandler.

All new unit tests and the full HTTP test suite (pytest packages/http/httpx/tests) pass cleanly locally (205 passed in 68.90s).

Whenever convenient, please take a look.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

🟡 Changes recommended

Transport cleanup removes the explicit request parent before retry-attempt and subsequent downstream spans can reuse it.

1 open issue

• Preserve request trace parent across retries · New

_{Review effort: Balanced}