Repository navigation
Remove unused SqliteTimestampToTextRangeIndex.get_timestamp_ranges (#374) - #377
Open
Kevin Turcios (KRRT7) wants to merge 1 commit into
Open
Kevin Turcios (KRRT7) wants to merge 1 commit into
Kevin Turcios (KRRT7) wants to merge 1 commit into
Conversation
…icrosoft#374) Only tests called it, and it no longer matched the index conventions: an inclusive range end instead of half-open [start, end), and millisecond-truncated comparisons without the exact recheck that lookup_range does.
Kevin Turcios (KRRT7)
marked this pull request as ready for review
October 25, 2026 09:16
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #374.
Behavior
Removes
SqliteTimestampToTextRangeIndex.get_timestamp_ranges. Nothing outside the tests called it, and it no longer followed the index's conventions:<=), whilelookup_rangeand the index protocol are half-open[start, end)(Email demo mbox #198).strftimevalues without the exact recheck thatlookup_rangedoes (fix: compare SQLite timestamp lookups at full precision #352).lookup_rangeis the supported way to query the index. No behavior changes for any caller in the repository.Validation
get_timestamp_rangesblocks fromtest_timestamp_operationsintests/test_sqlite_indexes.py; the test still coversadd_timestampandsize.git grep get_timestamp_rangesfinds no remaining references.make format check testpasses: 933 passed, 12 skipped.make ruffpasses.