Repository navigation
Flush headers for idle Streamable HTTP GET requests - #1159
Open
karthiksenv wants to merge 3 commits into
Open
karthiksenv wants to merge 3 commits into
karthiksenv wants to merge 3 commits into
Conversation
Author
|
@Kehrlann, could you review the intended idle Streamable HTTP header-flush behavior or route it to the servlet transport reviewer? The PR documents its regression test and broader-suite limitations. It currently has conflicts that need resolution and a fresh test run before merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An idle Streamable HTTP GET sends neither status nor headers until the first SSE event, causing clients to time out when keep-alive is disabled. Flush the servlet response after registering the listening stream so clients receive HTTP 200 and
Content-Type: text/event-streamimmediately.Adds an embedded-Tomcat regression test with keep-alive disabled. The test times out without the flush and passes with it.
Fixes #1155.
Updated against upstream
54e8b612. The merge resolves an import collision by retaining both the regression'sTimeUnitimport and upstream'sAtomicBooleanimport. The production change remains one line and preserves upstream's listening-stream lifecycle registration.Validation on Windows, Java 17.0.19, embedded Tomcat 11.0.27:
mvnw.cmd -pl mcp-test -am -Dtest=HttpServletStreamableIntegrationTests -Dsurefire.failIfNoSpecifiedTests=false test: 62 tests passed, no failures, errors, or skips. Maven also passed formatting validation and compiled the affected reactor modules.TimeoutExceptioningetStreamSendsHeadersBeforeFirstEvent(one test, one expected error).git diff --checkpassed.The full repository suite was not rerun for this merge. Earlier broader validation ran 823 mcp-test cases with 13 errors, including unavailable Docker/dependent initialization errors and a stdio timeout; it was not fully green. The reporter's exact JDK/Tomcat versions were not recreated.
This is an AI-assisted contribution. The existing repository-policy disclosure remains in
disclosure.txt.