Repository navigation
Allow packed data to be captured while executing skip(), etc. - #23
Merged
Merged
Conversation
Contributor
Author
|
Updated to current HEAD. |
methane
added a commit
that referenced
this pull request
Dec 6, 2012
Allow packed data to be captured while executing skip(), etc.
Contributor
Author
|
Great! I look forward to using this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One may want to acquire the bytes corresponding to a single msgpack message. For example, consider a server whose job is to forward messages to a set of workers.
In the first instance, it may not care what the messages contain, it just reads messages off a stream and passes them on to workers. With the current
msgpack-python, if the message length is not known, this requires unpacking and re-packing. Ideally one might wantUnpacker.read_packed(). This patch instead offers the idiom:Now consider the case that our server still passes on raw messages, but only those who have a particular value, say
route_to == 'me':This avoids packing. With
read_map_headersupporting a similar interface, the following does the same, but avoids full unpacking: