Skip to content

unpacker: Make default size limit smaller - #319

Merged
methane merged 1 commit into
msgpack:masterfrom
methane:lower-default-limit
Nov 8, 2018
Merged

methane merged 1 commit into
msgpack:masterfrom
methane:lower-default-limit

Conversation

@methane

@methane methane commented Nov 8, 2018

Copy link
Copy Markdown
Member

To avoid DoS attack, make default size limit smaller.

Fixes #295

To avoid DoS attack, make default size limit smaller.

Fixes #295
@methane
methane merged commit 3b80233 into msgpack:master Nov 8, 2018
@methane
methane deleted the lower-default-limit branch November 8, 2018 13:21
Comment thread msgpack/_unpacker.pyx
Limits max length of map. (default: 32*1024)

:param int max_ext_len:
Limits max length of map. (default: 1024*1024)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it's incorrect description.

Comment thread msgpack/fallback.py
Limits max length of map. (default: 32*1024)

:param int max_ext_len:
Limits max length of map. (default: 1024*1024)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is too (incorrect description).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants