Skip to content

test: fix cluster dgram 1 test on macos - #66986

Open
gegham1 wants to merge 1 commit into
nodejs:mainfrom
gegham1:fix-cluster-dgram-test-macos
Open

gegham1 wants to merge 1 commit into
nodejs:mainfrom
gegham1:fix-cluster-dgram-test-macos

Conversation

@gegham1

@gegham1 gegham1 commented Oct 24, 2026

Copy link
Copy Markdown

Send to localhostIPv4 instead of 0.0.0.0.
Add strict null equality assert on socket send callback error for failing fast in such cases.

Fixes: #60050

Context:

Starting from macOS Sequoia 15.0 (not 100% sure about the exact version, no official change log) when you send a UDP (or TCP) to 0.0.0.0 you get EHOSTUNREACH error. In this case we don't bind the port and host to the worker socket (we call socket.bind(0)) and that causes the worker udp socket to listen on 0.0.0.0:{random port}, and on line socket.send(buf, 0, buf.length, address.port, address.address, afterSend); we just send the request to 0.0.0.0 thus making workers to stuck.

Another fix would be passing the host in worker's socket.bind(0) call.

Send to localhostIPv4 instead of 0.0.0.0.
Add strict null equality assert on socket send callback error
for failing fast in such cases.

Fixes: nodejs#60050
Signed-off-by: gegham1 <geghamayvazyan9@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 90.58%. Comparing base (91c4436) to head (bb22360).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66986      +/-   ##
==========================================
- Coverage   92.93%   90.58%   -2.35%     
==========================================
  Files         428      797     +369     
  Lines      195236   278298   +83062     
  Branches    30176    53513   +23337     
==========================================
+ Hits       181442   252100   +70658     
- Misses      13467    16561    +3094     
- Partials      327     9637    +9310     

see 501 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parallel/test-cluster-dgram-1 times out on macOS 15.7

2 participants