Skip to content

inspector: safe teardown when permissions dropped during exit - #66995

Open
AdamMagued wants to merge 1 commit into
nodejs:mainfrom
AdamMagued:fix-issue-66973-permission-inspector-drop-exit
Open

AdamMagued wants to merge 1 commit into
nodejs:mainfrom
AdamMagued:fix-issue-66973-permission-inspector-drop-exit

Conversation

@AdamMagued

Copy link
Copy Markdown

Fix process termination and inspector disconnect assertion when permissions are dropped during exit.

Fixes: #66973

Signed-off-by: AdamMagued <adamismailmageud@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/inspector
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model. labels Oct 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:automated-account c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process.permission.drop('inspector') aborts Node with a HandleScope fatal during exit

2 participants