Repository navigation
Conversation
|
Review requested:
|
nodejs-github-bot
added
the
meta
panva
added
dont-land-on-v22.x
panva
changed the title
e529655 to
3050fa8
Compare
|
I'd prefer we align it with #66503, for consistency. FWIW force pushing does not invalidate previous approvals nor CI, but yeah someone needs to force push back the previous commit for the CQ to detect it |
|
I believe non-bot commit presence being a skip condition is orthogonal to what this change is for. It can come too, but isn't resolving what I'm trying to resolve. And I think it's solved here too as a side effect of not pushing over the same version update. |
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I don't think it's the right approach, we should fetch the PR_BRANCH first, apply it's changes before running the update-openssl.sh script
Replay the existing update branch onto the current target branch before running the updater on scheduled runs. Its version check then skips the same version without rewriting the PR, preserving approvals and CI. This also carries contributor commits into a newer update. Manual dispatches bypass the replay so the update can still be regenerated. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
3050fa8 to
a81cea7
Compare
|
Updated to replay the existing update branch before running the script, so its version check handles the no-op. And it also keeps non-bot commits as they were. Manual dispatch bypasses the replay to allow regeneration. |
Replay the existing update branch onto the current target branch before running the updater on scheduled runs. Its version check then skips the same version without rewriting the PR, preserving approvals and CI.
This also carries non-bot commits into a newer update. Manual dispatches bypass the replay so the update can still be regenerated.