Skip to content

build: remove unused FIPS export condition - #67005

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:remove-unused-fips-export-condition
Open

build: remove unused FIPS export condition#67005
panva wants to merge 1 commit into
nodejs:mainfrom
panva:remove-unused-fips-export-condition

Conversation

@panva

@panva panva commented Oct 25, 2026

Copy link
Copy Markdown
Member

@panva
build: remove unused FIPS export condition
2a5a84d 
Refs: nodejs#64777 (review)
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva requested a review from gurgunday October 25, 2026 21:43
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 25, 2026
@panva panva added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 25, 2026
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 26, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78650/

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes
@gurgunday gurgunday Awaiting requested review from gurgunday

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue PRs queued for automated landing through the Commit Queue. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panva @nodejs-github-bot @richardlau @aduh95