Repository navigation
Conversation
Each declarator copied the specifiers along with the anonymous struct, union or enum type they owned, so every symbol or field freed it. Declarators now borrow the type and the first one kept takes ownership; if none is kept, it is freed with the specifiers. Field lists regressed in 52c91f0.
zend_ffi_declare() and zend_ffi_add_enum_val() bailed out on a redeclaration without releasing the type they held. Free it before reporting the error.
devnexen
marked this pull request as ready for review
October 24, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.