Repository navigation
[requires.io] dependency update on master branch - #123
Conversation
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 13 13
Lines 1809 1809
Branches 209 209
=======================================
Hits 1785 1785
Misses 12 12
Partials 12 12 Continue to review full report at Codecov.
|
|
@mahmoud I can't review this because "I" submitted it, so please rubber stamp |
|
This includes stuff I'm not sure it should. |
* master: Couple more cleanup bits # Conflicts: # tox.ini
…dds type info to the signature now.
| skip_install = True | ||
|
|
||
| deps = | ||
| coverage==4.5.4 # rq.filter: <5 # coverage 5.0 drops Python 3.4 support |
There was a problem hiding this comment.
rq.filter doesn't seem to be working
There was a problem hiding this comment.
You have to commit it to master before it takes effect. Committing to this branch doesn't do anything.
There was a problem hiding this comment.
…12 days ago. Lemme reverting that again.
There was a problem hiding this comment.
I can't figure out what we need to do to tell requires.io to stop updating this. I must have the syntax wrong or something… @glyph ?
There was a problem hiding this comment.
I don't see comments-in-the-comment in any other projects I've done with requires.io, so maybe rather than:
coverage==4.5.4 # rq.filter: <5 # coverage 5.0 drops Python 3.4 support
do
# coverage 5.0 drops Python 3.4 support
coverage==4.5.4 # rq.filter: <5
And then close this PR to see what it does when it reopens it.
|
This PR is getting pretty wooly due to the Sphinx update… how about I break it into separate PR steps:
|
|
Please do! |
|
OK looks like this is all good now. Merging. |
No description provided.