main branch code cleanups for int_max_str_digits non-backportable TODOs #96512
Copy link
Copy link
Closed
Labels
3.12only security fixesonly security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancementA feature request or enhancement
Description
I had some post-merge TODOs ready in #96499 for improvements specific to the main (3.12) branch. This is a rollup issue for those, they're all small:
- Cleanup: Move
int_max_str_digitsinto PyConfig in 3.12. -
Useint32_torPy_ssize_tinstead ofintfor the max digits value internally. -
Minor feature: add PEP-578PySys_Audithook calls at the new ValueError raise spots. - Once this ships in 3.11.0: Update the version notes about it in the 3.12 docs to say 3.11 and remove the 3.12 whatsnew text about it. The original PR was created not knowing exactly when we'd be able to merge.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
3.12only security fixesonly security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancementA feature request or enhancement
Activity
isuruf commentedon Sep 18, 2022
Could the limit be a configuration option, so that people who build from source can configure the limit?
gpshead commentedon Sep 19, 2022
Lets have that be its own issue if someone comes up with a compelling use case for it.
My thinking in not including a configure flag to start with is that anyone who builds from source likely also carries patches to their sources so there isn't a good reason to offer a configure option. We don't want to encourage interpreters built and shipped in different environments to have different limits as that can create compatibility headaches for application and library authors potentially expanding their test matrix.
pythongh-96512: Update int_max_str docs to say 3.11.
gh-96512: Update int_max_str docs to say 3.11 (#96942)
pythongh-96512: Move int_max_str_digits setting to PyConfig
gh-96512: Move int_max_str_digits setting to PyConfig (#96944)
Merge branch 'main' into dictwatch