Skip to content

Adds support for building with VisualStudioVersion = 18.0 - #138980

Merged
zooba merged 1 commit into
python:mainfrom
zooba:vsbuild
Sep 16, 2025
Merged

Adds support for building with VisualStudioVersion = 18.0#138980
zooba merged 1 commit into
python:mainfrom
zooba:vsbuild

Conversation

@zooba

@zooba zooba commented Sep 16, 2025

Copy link
Copy Markdown
Member

No description provided.

@zooba
zooba requested a review from a team as a code owner September 16, 2025 13:16
@zooba zooba added OS-windows skip issue skip news build The build process and cross-build needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Sep 16, 2025
Fidget-Spinner
Fidget-Spinner approved these changes Sep 16, 2025
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I had to set my env var manually on my system to get CPython to build with VS2026 preview edition. Now I'm glad I won't have to anymore.

@zooba
zooba enabled auto-merge (squash) September 16, 2025 13:24
@zooba
zooba merged commit 6920fa4 into python:main Sep 16, 2025
61 checks passed
@miss-islington-app

miss-islington-app Bot commented Sep 16, 2025

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2025
@zooba @miss-islington
Adds support for building with VisualStudioVersion = 18.0 (pythonGH-1…
8fbba62 
…38980)

(cherry picked from commit 6920fa4)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2025
@zooba @miss-islington
Adds support for building with VisualStudioVersion = 18.0 (pythonGH-1…
00286a0 
…38980)

(cherry picked from commit 6920fa4)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app

bedevere-app Bot commented Sep 16, 2025

Copy link
Copy Markdown

GH-138984 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 16, 2025
@bedevere-app

bedevere-app Bot commented Sep 16, 2025

Copy link
Copy Markdown

GH-138985 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 16, 2025
zooba added a commit that referenced this pull request Sep 17, 2025
@miss-islington @zooba
Adds support for building with VisualStudioVersion = 18.0 (GH-138980)
0c751ca 
(cherry picked from commit 6920fa4)

Co-authored-by: Steve Dower <steve.dower@python.org>
zooba added a commit that referenced this pull request Oct 8, 2025
@miss-islington @zooba @encukou
Adds support for building with VisualStudioVersion = 18.0 (GH-138980)
d8898e1 
(cherry picked from commit 6920fa4)

Co-authored-by: Steve Dower <steve.dower@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
@jjhelmus jjhelmus mentioned this pull request Dec 10, 2025
Merged
d-rotanov-rogii added a commit to rogii-com/cpython that referenced this pull request Sep 24, 2026
@d-rotanov-rogii
STARSTEER-28862 Port VS 2026 toolset selection from upstream CPython:…
f1bc45b 
… VisualStudioVersion 18.0 -> PlatformToolset v145 (pythonGH-138980, pythonGH-144680)
@d-rotanov-rogii d-rotanov-rogii mentioned this pull request Oct 2, 2026
Merged
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 25, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

GH-160653 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 25, 2026
@bedevere-app

bedevere-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

GH-160654 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 25, 2026
@hugovk

hugovk commented Oct 25, 2026

Copy link
Copy Markdown
Member

Opening backports to test if it fixes the buildbots:

pablogsal pushed a commit that referenced this pull request Oct 25, 2026
@miss-islington @zooba
[3.11] Adds support for building with VisualStudioVersion = 18.0 (GH-…
95b8008 
…138980) (#160654)

Adds support for building with VisualStudioVersion = 18.0 (GH-138980)
(cherry picked from commit 6920fa4)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

build The build process and cross-build OS-windows skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zooba @hugovk @Fidget-Spinner