Skip to content

gh-148887: Remove version hardcoding in Tools/pixi-packages - #148890

Open
isuruf wants to merge 2 commits into
python:mainfrom
isuruf:rm-ver-pixi
Open

isuruf wants to merge 2 commits into
python:mainfrom
isuruf:rm-ver-pixi

Conversation

@isuruf

@isuruf isuruf commented Apr 22, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #148887 by using an experimental feature in rattler-build

cc @crusaderky @hugovk @ngoldbaum

@isuruf
isuruf marked this pull request as ready for review April 22, 2026 19:32
@hugovk hugovk added skip news infra CI, GitHub Actions, buildbots, Dependabot, etc. labels Apr 22, 2026
Comment thread Tools/pixi-packages/default/recipe.yaml Outdated

context:
# Keep up to date
version: ${{ git.latest_tag(".")[1:] }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags start with v, for example: v3.15.0a8. Does that need stripping?

Also, in two weeks, we'll branch main to a 3.15 branch, and main will become the home for 3.16.

There won't be any 3.16 tags until October.

https://peps.python.org/pep-0826/

Will that cause a problem?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags start with v, for example: v3.15.0a8. Does that need stripping?

Yes, I've stripped v by doing [1:].

There won't be any 3.16 tags until October.

Yes, that'll cause an issue if git describe --tags shows 3.15 instead of 3.16.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review infra CI, GitHub Actions, buildbots, Dependabot, etc. skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove hard-coded python version in Tools/pixi-packages #148858

2 participants