Skip to content

gh-157354: Honor --with-<name>-sanitizer=no and --without-<name>-sanitizer in configure - #157355

Merged
StanFromIreland merged 5 commits into
python:mainfrom
lpyu001:configure2
Oct 25, 2026
Merged

gh-157354: Honor --with-<name>-sanitizer=no and --without-<name>-sanitizer in configure#157355
StanFromIreland merged 5 commits into
python:mainfrom
lpyu001:configure2

Conversation

@lpyu001

@lpyu001 lpyu001 commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Honor =no and --without-... for all four sanitizer options while preserving the existing behavior for other explicitly supplied values.

@bedevere-app bedevere-app Bot mentioned this pull request Sep 12, 2026
Closed
@StanFromIreland

StanFromIreland commented Oct 23, 2026

Copy link
Copy Markdown
Member

Please update the branch, and include HWAsan.

@lpyu001

lpyu001 commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

Also fix test.support.check_sanitizer() so --with-<X>-sanitizer=no builds are not detected as sanitizer builds.

@StanFromIreland StanFromIreland changed the title gh-157354 : Honor disabled sanitizer configure options gh-157354: Honor disabled sanitizer configure options Oct 24, 2026
StanFromIreland
StanFromIreland reviewed Oct 24, 2026
View reviewed changes
Comment thread Lib/test/test_support.py Outdated
StanFromIreland
StanFromIreland reviewed Oct 24, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Build/2026-09-12-15-33-26.gh-issue-157354.2hw6fe.rst Outdated
@StanFromIreland StanFromIreland changed the title gh-157354: Honor disabled sanitizer configure options gh-157354: Honor --with-<name>-sanitizer=no and --without-<name>-sanitizer in configure Oct 25, 2026
@StanFromIreland
StanFromIreland merged commit ea3a97f into python:main Oct 25, 2026
61 checks passed
@StanFromIreland StanFromIreland added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 25, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Sorry, @lpyu001 and @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker ea3a97f2458a204e6273936eabe18bd465f4ed24 3.14

@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Sorry, @lpyu001 and @StanFromIreland, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker ea3a97f2458a204e6273936eabe18bd465f4ed24 3.15

@StanFromIreland

StanFromIreland commented Oct 25, 2026

Copy link
Copy Markdown
Member

Can you please do the backports?

@lpyu001

lpyu001 commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

Sure, but due to the new PR limit policy ,I'm currently unable to open any new PRs. I may have to wait until the community relaxes the restrictions on backport PRs.

@StanFromIreland

StanFromIreland commented Oct 25, 2026

Copy link
Copy Markdown
Member

You should be able to open them now.

@bedevere-app

bedevere-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

GH-160655 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 25, 2026
@bedevere-app

bedevere-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

GH-160656 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 25, 2026
@bedevere-app

bedevere-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

GH-160655 is a backport of this pull request to the 3.15 branch.

StanFromIreland pushed a commit that referenced this pull request Oct 25, 2026
@lpyu001
[3.15] gh-157354: Honor --with-<name>-sanitizer=no and `--without-<…
cd3d050 
…name>-sanitizer` in configure (GH-157355) (#160655)
StanFromIreland pushed a commit that referenced this pull request Oct 25, 2026
@lpyu001
[3.14] gh-157354: Honor --with-<name>-sanitizer=no and `--without-<…
142aa9b 
…name>-sanitizer` in configure (GH-157355) (#160656)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro is a code owner

Assignees

@StanFromIreland StanFromIreland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lpyu001 @StanFromIreland