Skip to content

gh-158304: Avoid creating StopIteration for every value yielded by an async generator - #158315

Merged
kumaraditya303 merged 8 commits into
python:mainfrom
ashm-dev:gh-158304
Oct 22, 2026
Merged

kumaraditya303 merged 8 commits into
python:mainfrom
ashm-dev:gh-158304

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

@ashm-dev

Copy link
Copy Markdown
Contributor Author

@kumaraditya303 @colesbury could you please review my PR?

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not a full review)

Comment thread Objects/genobject.c Outdated
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Sep 28, 2026
Comment thread Objects/genobject.c
Comment thread Objects/genobject.c
@ashm-dev

Copy link
Copy Markdown
Contributor Author

gentle ping

Comment thread Objects/genobject.c
@markshannon

markshannon commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

This looks good overall.
Do you have any numbers for the (presumably positive) performance impact?

@sobolevn

Copy link
Copy Markdown
Member

I've seen these numbers in the original issue #158304
Снимок экрана 2026-10-21 в 21 30 03

@kumaraditya303
kumaraditya303 merged commit ac430e3 into python:main Oct 22, 2026
59 of 60 checks passed
@ashm-dev
ashm-dev deleted the gh-158304 branch October 22, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants