Repository navigation
[3.13] gh-159015: Fix test_math import on musl - #159016
Merged
Merged
Conversation
The 3.13 backport of pythongh-152563 compares the return value of support.linked_to_musl() with a version tuple, but on 3.13 the helper still returns a bool. On musl this raises TypeError at class definition time, so test_math and test_cmath fail to import. Restore the previous skip condition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
All commit authors signed the Contributor License Agreement. |
vstinner
approved these changes
Oct 8, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. The issue #159015 prevents building Python with PGO on Alpine Linux, it's quite bad. IMO the issue is important enough to justify merging it in the 3.13 security-only branch.
@Yhg1s: Would you be ok to include this fix?
Currently, test_math fails this way on Alpine Linux:
~/python/3.13 # ./python -m test -v test_math
...
test test_math crashed -- Traceback (most recent call last):
...
TypeError: '<' not supported between instances of 'bool' and 'tuple'
The only Alpine buildbot that we have didn't catch this major regression because it only runs on Python 3.14 and newer:
cpw(
name="ware-alpine",
tags=['linux', 'unix', 'alpine', 'docker', 'amd64', 'x86-64', 'musl'],
branches=BRANCHES.only_since(3, 14),
parallel_tests=6,
),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3.13 backport of gh-152563 (#155753) changed the skip condition of
test_fma_zero_resulttosupport.linked_to_musl() < (1, 2, 6). That works onmain/3.14, wherelinked_to_musl()returns the musl version tuple (gh-90548). On 3.13 it still returns abool, so on musl the condition raisesTypeErrorwhile the class is being defined.test_maththen fails to import, andtest_cmath(which imports from it) fails too. This breaks--enable-optimizationsbuilds of 3.13.16 on Alpine.This PR restores the previous condition, so the test is skipped on musl again, as it was before 3.13.16. It's a 3.13-only fix;
mainand 3.14 are not affected.cc @vstinner
🤖 Generated with Claude Code