Repository navigation
[3.15] gh-154594: Fix deepcopy memo lookup when __deepcopy__ returns None (GH-154595) - #159255
Merged
Merged
Conversation
…one (pythonGH-154595) * pythongh-154594: Fix deepcopy memo lookup when __deepcopy__ returns None * Use 'd in memo' lookup instead of a sentinel Addresses review: clearer, no sentinel, and the test treats memo as opaque. * Apply review suggestions: shorten NEWS, use class attribute in test --------- (cherry picked from commit 5539c2a) Co-authored-by: tonghuaroot (童话) <tonghuaroot@gmail.com> Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
eendebakpt
approved these changes
Oct 12, 2026
eendebakpt
enabled auto-merge (squash)
October 12, 2026 20:22
bernhard-42
added a commit
to bernhard-42/build123d
that referenced
this pull request
Oct 25, 2026
Python 3.15.1 fixed the None memo lookup in copy.deepcopy (python/cpython#159255), so Compound._global_elements works again with upstream's None memo entries. Revert 9d3db2b and f52cad9, back to upstream's code, and pin the CI 3.15 job to 3.15.1, because 3.15.0 still breaks three tests in test_intersection.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy.deepcopy memo lookup fails when __deepcopy__ returns None #154594: Fix deepcopy memo lookup when deepcopy returns None
Use 'd in memo' lookup instead of a sentinel
Addresses review: clearer, no sentinel, and the test treats memo as opaque.
(cherry picked from commit 5539c2a)
Co-authored-by: tonghuaroot (童话) tonghuaroot@gmail.com
Co-authored-by: Pieter Eendebak pieter.eendebak@gmail.com