Repository navigation
gh-114258: Use Argument Clinic for __repr__ - #160011
Merged
Merged
Conversation
ZeroIntensity
requested review from
AA-Turner,
erlend-aasland,
markshannon and
methane
as code owners
October 21, 2026 03:02
corona10
reviewed
Oct 21, 2026
| (): 'tp_iternext', | ||
| }), | ||
| '__repr__': SlotSpec('__repr__', 'PyObject *', 'object', { | ||
| (): 'tp_repr', |
Member
There was a problem hiding this comment.
Oh, I found this definition design is weird. I will submit the new PR for this. Can you rebase it?
Member
Author
There was a problem hiding this comment.
Sure, tag me for a review.
Member
There was a problem hiding this comment.
After #160012 is merged,
you can simply declare with
'__repr__': (
SlotSpec(return_converter='object'),
),
ZeroIntensity
enabled auto-merge (squash)
October 21, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.