Repository navigation
gh-160043: Don't reject fitting text in textwrap.shorten() and wrap(max_lines) - #160044
Open
tonghuaroot wants to merge 1 commit into
Open
tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…(max_lines) The placeholder-fits guard ran eagerly whenever max_lines was set, so shorten() and wrap() raised ValueError for text that fits in width when the placeholder was wider than width. Move the check to the branch that force-places a placeholder-only line, where the placeholder is actually used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shorten()andwrap()with max_lines no longer raiseValueError("placeholder too large for max width")for text that fits inwidth.
shorten's docstring promises such text is "returned as is".The guard's real purpose is to never emit a placeholder-only line wider than
width, but it ran eagerly whenever max_lines was set, before any wrapping,
so it rejected text that never needed a placeholder. Moving the identical
check to the single branch that force-places a placeholder-only line preserves
that invariant: it still raises on every genuine truncation that cannot place
the placeholder, while text that fits (or a truncation that can append the
placeholder to the previous line) no longer raises.