Repository navigation
gh-139122: Fix crash when pickling a C UUID without is_safe - #160574
Open
tonghuaroot wants to merge 1 commit into
Open
tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
UUID.__getstate__() passed a NULL is_safe to PyDict_SetItem() for every UUID created without is_safe. Omit the key, as the Python version does for SafeUUID.unknown.
bedevere-app
Bot
added
awaiting review
type-feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C
UUID.__getstate__()passesself->is_safetoPyDict_SetItem()even when it is NULL, which is the case for every UUID created withoutis_safe(uuid4(),uuid7(),UUID(hex),UUID(int=...)). Pickling or copying such a UUID aborts on a debug build and segfaults on a release build:Omit the key in that case, as the pure Python
__getstate__()does forSafeUUID.unknown. The C implementation is unreleased, so there is no NEWS entry.