Repository navigation
gh-139122: Reset the cached hash of C UUIDs in __init__ and __setstate__ - #160575
Open
tonghuaroot wants to merge 1 commit into
Open
tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…etstate__ Subclass instances are allocated zeroed, so cached_hash started at 0 and hash() returned 0. Re-initializing an existing UUID also kept the old hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python subclasses of
uuid.UUIDare allocated withPyType_GenericAlloc(), socached_hashstarts at 0 instead of -1 and__init__()never resets it. With the C implementation every subclass instance hashes to 0 and is not found next to an equalUUIDin a set or dict:Calling
__init__()or__setstate__()on an existing UUID also kept its old cached hash. Resetcached_hashin both. The C implementation is unreleased, so there is no NEWS entry.