Repository navigation
gh-160598: Preserve Babyl labels when reopening mailboxes - #160604
Open
kinqsradio wants to merge 1 commit into
Open
kinqsradio wants to merge 1 commit into
kinqsradio wants to merge 1 commit into
Conversation
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160598.
Reopening a Babyl mailbox left message labels as bytes even though the message APIs and writers expect strings. This could mark an unseen message as read when converting it to another mailbox format, include special labels in
Babyl.get_labels(), and raiseAttributeErrorwhen rewriting or copying labeled messages.Decode labels as UTF-8 when reading the table of contents and use
surrogateescapewhen reading and writing labels so existing non-UTF-8 label bytes survive a round trip. Add regression tests for reopening, special-label filtering, read-flag conversion, copying, and rewriting, including Unicode and invalid UTF-8 labels.Validation:
./python.exe -m test test_mailboxsucceeds on a local macOS arm64 CPython 3.16 build (388 tests reported, 3 skipped).git diff --checkpass.AI assistance was used to investigate the issue, prepare the patch and tests, and run local validation.