Repository navigation
gh-160601: Handle surrogate characters in sampling profiler binary output - #160615
Open
zolaski333 wants to merge 1 commit into
Open
zolaski333 wants to merge 1 commit into
zolaski333 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode sampled filenames and function names using UTF-8 with
backslashreplace, preventingUnicodeEncodeErrorwhen they contain surrogate characters. The string table remains valid UTF-8 and compatible with the existing reader.Add regression coverage for surrogate characters in both filenames and function names, including mixed Unicode names and repeated samples.
Validation on Windows:
test_profiling: passed.-R 3:3: passed, no leaks detected.patchcheckandgit diff --check: passed.Zstd compression was unavailable in this Windows build.
profiling.samplingin--binarymode raises aUnicodeEncodeErrorwhile collecting the samples #160601