[jkloth]

Update Windows wait timeout handling to match the behavior for POSIX. This PR also catches overly values that would conflict with the INFINITE timeout value used in _winapi.WaitForSingleObject.

These changes should be backported to the maintenance branches.

https://bugs.python.org/issue46716

• Issue: regrtest didn't respect the timeout when running test_subprocess on AMD64 Windows11 3.x #90872

[eryksun]

Did you want to create an issue to fix _winapi.WaitForSingleObject() or the DWORD converter in _winapi? I suppose all call sites of _winapi functions that take DWORD parameters will have to be checked.

[jkloth]

I was thinking to the DWORD converter change as a separate PR that would not be a candidate for backport. While _winapi contents are considered "private", I know that when I write scripts only for use on Windows, I'll reach for that module for functions before considering using ctypes. All the needed "wrapping stuff" (exceptions for errors, reference counting, etc) is handled for me.

The change of negative values to exceptions, while probably not relied upon, would be a breaking change for a dot release. Being limited to a new release (3.11) would be easier to reason about downstream rather than a "random" bugfix release (say, 3.9.12). IMO.

[serhiy-storchaka]

Please add tests and a NEWS entry.

[serhiy-storchaka]

How difficult is to write tests?

[eryksun]

How difficult is to write tests?

Tests can spawn a child process that exits after a few seconds. With this PR, a timeout that's larger than 4294967.295 should raise OverflowError. For example, the current implementation mistakenly wraps 4294968 around to 0.704, leading to TimeoutExpired. With this PR, a negative timeout should be handled as 0. For example, the current implementation wraps -1 to 4294966.296, and the wait will succeed when the child exits, instead of raising TimeoutExpired.

[StanFromIreland]

The issue has been closed, is there anything left to do here?

[github-actions]

This PR is stale because it has been open for 30 days with no activity.

[ambv]

This PR is attached to gh-90872, which is already completed: the fix for that issue landed through other changes, and this PR's approach was not taken or has since become obsolete. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer.