Repository navigation
Honor declared map dimensions in world patterns - #86
Open
civilwarinfrance wants to merge 2 commits into
Open
civilwarinfrance wants to merge 2 commits into
civilwarinfrance wants to merge 2 commits into
Conversation
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
World patterns currently reuse the grid multipliers as each map's dimensions, ignoring the documented mapWidth and mapHeight overrides. Read each declared size and fall back to its multiplier only when omitted. Keep placement based on the original multipliers and offsets, and add the two size keys as optional TypedDict fields.
Specification: https://doc.mapeditor.org/en/stable/manual/worlds/#showing-only-direct-neighbors
Five regressions fail upstream and the default-size control passes. Tests check width-only, height-only, both, explicit zero values, filename matching, and unchanged negative-coordinate placement through parse_world. All 132 full-suite tests pass. Mypy, Black, and isort pass; Ruff and flake8 add no findings compared with upstream.
AI-assisted by Codex (GPT-6); prepared and tested by the assistant.